Add InstrumentationValidationParameters to QueryComplexityInfo#2558
Merged
bbakerman merged 1 commit intographql-java:masterfrom Oct 2, 2021
Merged
Add InstrumentationValidationParameters to QueryComplexityInfo#2558bbakerman merged 1 commit intographql-java:masterfrom
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
bbakerman
approved these changes
Sep 23, 2021
Member
bbakerman
left a comment
bbakerman
left a comment
There was a problem hiding this comment.
Thanks for this PR.
I had a concern that the raw parameters would to "wide" but given that MaxQueryComplexityInstrumentation is an instrumentation anyway, giving access to the validtion parameters is ok
Contributor
Author
|
@bbakerman thanks! Would you be able to merge this for me? |
|
any word on when the next release will be that would include these changes? |
Member
|
Every merge to master results in a timestamped release of graphql-java in
Maven central
So you can update if you need to.
As for the release, we havent convened to decide when - Typically its every
6 months or so but...that is not set in stone
…On Wed, 24 Nov 2021 at 04:59, Doug Tangren ***@***.***> wrote:
any word on when the next release will be that would include these changes?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2558 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMVWSOEZW5XRWK3WXVZTZ3UNPI7TANCNFSM5EP3P76A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #2547