Merged
Conversation
andimarek
requested changes
Jan 12, 2022
| } | ||
|
|
||
|
|
||
| private final static Set<String> SPECIFIED_DIRECTIVES = ImmutableSet.of( |
Member
There was a problem hiding this comment.
we have the same methods/logic already in DirectiveInfo I believe.
| @Internal | ||
| static class Builder { | ||
| Map<String, Integer> fieldReferenceCounts = new HashMap<>(); | ||
| Map<String, Integer> inputFieldReferenceCounts = new HashMap<>(); |
Member
There was a problem hiding this comment.
I would recommend ImmutableMaps.Builder here, which preserve the order and are immutable OR our beloved LinkedHashMap or a comment why the order is never interesting.
Member
Author
There was a problem hiding this comment.
ImmutableMap.Builder does not support compute like behavior. I want to accumulate values (counts) against type names.
private BiFunction<String, Integer, Integer> incCount() {
return (k, v) -> v == null ? 1 : v + 1;
}
builder.fieldReferenceCounts.compute(fieldType.getName(), incCount());
With map builder it has only PUT and no read capability for past values
So I cant use it. I do use it on getters however. I will improve it to create these once and once only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR on getting schema usage stats and "reference" ability