added optional content_type to bucket.upload_file#883
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
Looks fine. Any reason why you don't just use the |
|
not particularly, either works |
|
I think we've even debated making Can you address the test failure: |
|
hm.. the test passes for me |
|
Thanks. You are running the tests locally via |
|
yes, I am also using the code in production |
|
Notice it's a test fixture |
* chore(python): fix typo in README Source-Link: googleapis/synthtool@93e1685 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
* chore(python): fix typo in README Source-Link: googleapis/synthtool@93e1685 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Source-Link: googleapis/synthtool@aa69fb7 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Small change to fix bug noticed in googleapis/python-dialogflow#288. The import was `from google.rpc import status_pb2` but code expected `gr_status`
…mplates/python_library/.kokoro (#883) Source-Link: googleapis/synthtool@30bd01b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-api-core: 2.29.0</summary> ## [2.29.0](googleapis/python-api-core@v2.28.1...v2.29.0) (2026-01-08) ### Features * make parse_version_to_tuple public (#864) ([c969186f](googleapis/python-api-core@c969186f)) * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f96](googleapis/python-api-core@f8bf6f96)) ### Bug Fixes * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e2](googleapis/python-api-core@628003e2)) * Log version check errors (#858) ([6493118c](googleapis/python-api-core@6493118c)) * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([93404080](googleapis/python-api-core@93404080)) * closes tailing streams in bidi classes. (#851) ([c97b3a00](googleapis/python-api-core@c97b3a00)) </details>
Fixed language issues. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕 Co-authored-by: pallabiwrites <87546424+pallabiwrites@users.noreply.github.com>
Made changes that override api endpoint information while triggering builds from kokoro . All tests against prod are still successful. Some system tests are currently incompatible with nonprod environments and hence are marked to be skipped if endpoint is being overriden.
No description provided.