X Tutup
Skip to content

Install a fake local grpc-google-iam-v1 to resolve the version conflict.#2457

Closed
dhermes wants to merge 1 commit intomasterfrom
fake-out-rtd
Closed

Install a fake local grpc-google-iam-v1 to resolve the version conflict.#2457
dhermes wants to merge 1 commit intomasterfrom
fake-out-rtd

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 28, 2016 •
edited
Loading

See https://readthedocs.org/projects/google-cloud-python/builds/4449660/ for validation of this fact (at 388b9bf). This is a temporary hack to workaround the fact that the latest (0.10.1) gapic-google-pubsub-v1 relies on grpc-google-iam-v1 0.10.0, but they have contradicting bounds on oauth2client:

Fixes #2405.

WORTH NOTING: I am sending the PR from a branch I created on GoogleCloudPlatform. I created it here so I could test if the hack worked on RTD without having to keep behaving badly with premature merges.

/cc @bjwatson

ASIDE: @tseaver @jonparrott Any idea why pip is cool with the version conflict but setuptools isn't? (Evidence: python setup.py install fails at the "Processing dependencies" step with the conflict described above, but pip is happy to let it happen.)

@dhermes dhermes added the docs label Sep 28, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2016
@theacodes
Copy link
Contributor

theacodes commented Sep 28, 2016

@dhermes not sure - what does pip say is the collected and installed packages when you do it?

@theacodes
Copy link
Contributor

theacodes commented Sep 28, 2016

@bjwatson it's pretty easy to support a wide range of oauth2client versions, any reason to keep the bounds so tight?

@dhermes
Copy link
Contributor Author

dhermes commented Sep 28, 2016

Only failure was pylint on my fake directory: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/163282822#L1000

Just added grpc-google-iam-v1-fake to IGNORED_DIRECTORIES and pushed over the original commit.

@tseaver Any issues with merging this while we wait for the version conflict to be resolved?

@tseaver
Copy link
Contributor

tseaver commented Sep 28, 2016

https://pypi.python.org/pypi/grpc-google-iam-v1/0.9.0 and https://pypi.python.org/pypi/grpc-google-iam-v1/0.10.1 are released.

@bjwatson
Copy link

bjwatson commented Sep 28, 2016 •
edited
Loading

@jonparrott Paranoia, per semver. I can relax it. What do you suggest? >=1.4.11, <4.0.0?

@bjwatson bjwatson mentioned this pull request Sep 28, 2016
Merged
@dhermes
Copy link
Contributor Author

dhermes commented Sep 29, 2016

Best closed PR ever!

I just manually rebuilt latest (at 5a0e492) at it succeeded: https://readthedocs.org/projects/google-cloud-python/builds/4453698/

@dhermes dhermes closed this Sep 29, 2016
@dhermes dhermes deleted the fake-out-rtd branch September 29, 2016 00:02
@bjwatson bjwatson mentioned this pull request Sep 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tseaver tseaver

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dhermes @theacodes @tseaver @bjwatson @daspecster @googlebot
X Tutup