Fix "Send Key(s) to RESET" not appearing on first right-click in Animation Editor#117273
Open
rinevard wants to merge 1 commit intogodotengine:masterfrom
Open
Fix "Send Key(s) to RESET" not appearing on first right-click in Animation Editor#117273rinevard wants to merge 1 commit intogodotengine:masterfrom
rinevard wants to merge 1 commit intogodotengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117100.
The cause of issue is that
selection(the selected keys) is updated next frame due to a deferred signal connection (CONNECT_DEFERRED), butAnimationTrackEditor::can_add_reset_keyrelis on its value at this frame. This commit extracts the menu pop up logic as a single function and usescall_deferredto call it to use the updatedselection.For context,
selectionis updated by_try_select_at_ui_pos->emit_signal(SNAME("select_key"), key_idx, true)->AnimationTrackEditor::_key_selectedand is used inAnimationTrackEditor::can_add_reset_key.