Rewrite SSIL (which approximates global illumination using screen space information)#117241
Draft
MopanionStudios wants to merge 7 commits intogodotengine:masterfrom
Draft
Rewrite SSIL (which approximates global illumination using screen space information)#117241MopanionStudios wants to merge 7 commits intogodotengine:masterfrom
MopanionStudios wants to merge 7 commits intogodotengine:masterfrom
Conversation
|
Looks amazing , though i'd recommend adding other test screenshot of test scenarios, like in dark areas where there is a emissive object moving around or in other light types. Will test soon or prob when the artifacts are ready. Amazing job homie. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewritten SSIL logic
Adresses Improve SSIL/SSAO
The current state of Godot's SSIL can be seen as quite far behind compared to current state of the art implementations, and so I have rewritten the current SSIL logic to generally match the performance of the current SSIL, but with a more modern, up-to-date approach. I have discussed it quite a bit in the rendering channel.
This approach uses visibility bitmasks, a relatively new method for screen space effects such as AO and GI, that keeps a far more accurate track of occlusion by storing visibility in a 32-bit "bitmask", with each bit representing that sector's visibility. This allows for far more appealing, accurate visuals at a relatively minimal added cost, and was easily shared between AO & GI since it is derived from GTAO-VB logic. This technique has been pretty well documented and I will leave some references I used below.
The most prominent changes made are as such:
Showcase
(intensity 1.0, ao strength 0.5, thickness 0.3, backface rejection enabled, radius 1.6-2.0):




(intensity 1.0, ao strength 0.5, normal rejection 1.0, radius 5.0)
Changes needed
I am going to be quite busy for about a week, so I won't have space to work on this for that time. This is still a draft PR, as its not finished and I have hopes that I can gain feedback to improve this (ideally I'll have made a stupid mistake in code and once I fix it the quality improves ten-fold... lol). To go into detail about the "vortex" issue, I'd suggest using medium quality and aiming the center of the screen at an area with lots of indirect illumination. I don't know what causes it, totally stumped, but it creates a strange vortex-ish shape in the center of the screen. On top of that, at lower quality settings, the gap between slices/samples becomes quite apparent, and so it does not scale well between quality, especially compared to the current SSIL. Some help on those issues would be great!
References/Inspiration