Add support for bool and Vector in @GlobalScope.min() and .max()#117240
Open
EdwardChanCH wants to merge 2 commits intogodotengine:masterfrom
Open
Add support for bool and Vector in @GlobalScope.min() and .max()#117240EdwardChanCH wants to merge 2 commits intogodotengine:masterfrom
bool and Vector in @GlobalScope.min() and .max()#117240EdwardChanCH wants to merge 2 commits intogodotengine:masterfrom
Conversation
GlobalScope.min() and .max() not accepting boolGlobalScope.min() and .max() not accepting bool
Contributor
Author
|
Not sure if I should change the error message here or in a separate PR. |
GlobalScope.min() and .max() not accepting boolbool in GlobalScope.min() and .max()
Member
|
Note that the documentation needs to be updated as well to mention |
Contributor
Author
|
Now that you mentioned it, the Godot Doc implies that Edit: I updated the docs and code to also accept |
bool in GlobalScope.min() and .max()bool and Vector in @GlobalScope.min() and .max()
986e73e to
19330f7
Compare
19330f7 to
74eeef4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: godotengine/godot-proposals#14402