Avoid reading from sky pointer when rendering background without sky#115874
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Feb 5, 2026
Merged
Avoid reading from sky pointer when rendering background without sky#115874Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
clayjohn
added
the
cherrypick:4.6
Calinou
approved these changes
Feb 4, 2026
Member
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
I can confirm the crash no longer occurs when following the steps that led to the crash in #115861 (comment).
blueskythlikesclouds
approved these changes
Feb 5, 2026
Contributor
|
Thanks! |
Contributor
|
Cherry-picked for 4.6.1. |
Repiteo
removed
the
cherrypick:4.6
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
Avoid reading from sky pointer when rendering background without sky
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #115861
Regression from #115606
The sky render function can be called with a dummy sky material in a few cases, so we need to check for the existence of the sky.
For people who want to test this, the repro steps in #115861 aren't enough to cause the crash. You need to enable "fog" in the Environment and you need the background mode to be set to clear color.
Flagging for cherrypicking so we can add #115606 to 4.6.1