Revert "Improve performance of CSharpLanguage::reload_assemblies"#115759
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Feb 4, 2026
Merged
Revert "Improve performance of CSharpLanguage::reload_assemblies"#115759Repiteo merged 1 commit intogodotengine:masterfrom
CSharpLanguage::reload_assemblies"#115759Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
This reverts commit f68bf2f. This seems to trigger occasional editor crashes. Fixes godotengine#115460.
akien-mga
added
bug
topic:dotnet
crash
regression
cherrypick:4.6
akien-mga
changed the title
CSharpLanguage::reload_assemblies"
raulsntos
approved these changes
Feb 3, 2026
Contributor
|
Thanks! |
Contributor
|
Cherry-picked for 4.6.1. |
Repiteo
removed
the
cherrypick:4.6
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
Revert "Improve performance of `CSharpLanguage::reload_assemblies`"
|
thanks for the work! |
Contributor
|
@akien-mga Thanks for the heads-up. I’ll take another look at this optimization and see if we can avoid the regressions in #115460. Without it, projects with hundreds of C# scripts will cause the editor to freeze for up to a minute during builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f68bf2f / #106299.
This seems to trigger occasional editor crashes.
ERROR: Task 'update_scripts_classes' already exists.#115460.FYI @Ryan-000 - might be worth another attempt at this optimization that ensures it doesn't trigger the issues in #115460.