LSP: Add godot to known language ids#115671
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Jan 31, 2026
Merged
Conversation
akien-mga
approved these changes
Jan 31, 2026
akien-mga
reviewed
Jan 31, 2026
Comment on lines
+698
to
+701
| // Clients should use "gdscript" as language id, but we can't enforce it. | ||
| // We normalize some known ids to make them easier to work with: | ||
| // Rider: "gd" | ||
| // Kate: "godot" |
Member
There was a problem hiding this comment.
FYI @van800. I assume we'll have to keep supporting gd for a while for compatibility, but it could make sense for Rider to start using gdscript.
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Yes, this one was fixed in Rider 2026.1 EAP 2, thank you for mentioning.
Member
There was a problem hiding this comment.
Great, thanks!
Might be worth mentioning in the comment: "Rider < 2026.1:"
a17418b to
9c72daf
Compare
Member
|
Thanks! |
Contributor
|
Cherry-picked for 4.6.1. |
rivie13
pushed a commit
to rivie13/Phoenix-Agentic-Engine
that referenced
this pull request
Feb 16, 2026
LSP: Add `godot` to known language ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115631 (not the error spam though)
Kate currently uses
godotas language id for GDScript. I will probably try to upstream a change togdscriptat some point but for now we just handle this id like GDScript.