X Tutup
Skip to content

LSP: Add godot to known language ids#115671

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
HolonProduction:lsp/kate
Jan 31, 2026
Merged

LSP: Add godot to known language ids#115671
akien-mga merged 1 commit intogodotengine:masterfrom
HolonProduction:lsp/kate

Conversation

@HolonProduction
Copy link
Member

Fixes #115631 (not the error spam though)

Kate currently uses godot as language id for GDScript. I will probably try to upstream a change to gdscript at some point but for now we just handle this id like GDScript.

@HolonProduction HolonProduction added this to the 4.7 milestone Jan 31, 2026
@HolonProduction HolonProduction requested a review from a team as a code owner January 31, 2026 12:26
@HolonProduction HolonProduction added bug topic:gdscript topic:editor regression cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release labels Jan 31, 2026
Comment on lines +698 to +701
// Clients should use "gdscript" as language id, but we can't enforce it.
// We normalize some known ids to make them easier to work with:
// Rider: "gd"
// Kate: "godot"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @van800. I assume we'll have to keep supporting gd for a while for compatibility, but it could make sense for Rider to start using gdscript.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this one was fixed in Rider 2026.1 EAP 2, thank you for mentioning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Might be worth mentioning in the comment: "Rider < 2026.1:"

@akien-mga akien-mga merged commit 6a3158b into godotengine:master Jan 31, 2026
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@HolonProduction HolonProduction deleted the lsp/kate branch January 31, 2026 22:08
@Repiteo
Copy link
Contributor

Repiteo commented Feb 5, 2026

Cherry-picked for 4.6.1.

@Repiteo Repiteo removed the cherrypick:4.6 Considered for cherry-picking into a future 4.6.x release label Feb 5, 2026
rivie13 pushed a commit to rivie13/Phoenix-Agentic-Engine that referenced this pull request Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4.6] LSP functionality is broken on KDE's Kate Editor

4 participants

X Tutup