Metal: Ensure correct output texture format selection#109406
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Aug 8, 2025
Merged
Metal: Ensure correct output texture format selection#109406Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
stuartcarnie
added
the
cherrypick:4.4
github-project-automation
bot
moved this to Unassessed
in 4.x Release Priorities & Blockers
Calinou
moved this from Unassessed
to Release Blocker
in 4.x Release Priorities & Blockers
6 tasks
clayjohn
approved these changes
Aug 8, 2025
Contributor
Author
|
I have an addition to this PR, as it doesn't handle toggling the viewport from HDR to SDR. |
stuartcarnie
force-pushed
the
metal_fx_spatial_fix
branch
from
bc19cf7 to
c8b5982
Compare
Contributor
Author
|
@clayjohn I added a call to CleanShot.2025-08-08.at.12.52.57.mp4 |
bruvzg
approved these changes
Aug 8, 2025
Member
bruvzg
left a comment
bruvzg
left a comment
There was a problem hiding this comment.
I can reproduce the issue and confirm it is fixed. Tested on M4 Pro, macOS 15.6 (24G84).
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the correct output texture format is selected when creating the MetalFX Spatial Shader context.
Note
Also verified with tps-demo and @Calinou's additions to allow selecting MetalFX upscalers.