Remove custom --language-in arg for the Closure compiler#100525
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Mar 11, 2025
Merged
Remove custom --language-in arg for the Closure compiler#100525Repiteo merged 1 commit intogodotengine:masterfrom
--language-in arg for the Closure compiler#100525Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Repiteo
approved these changes
Mar 11, 2025
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Upgrading emscription version is an inevitability, so I'm fine with handling this ahead of time
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes our custom set of
--language-infor the Closure compiler, especially since emscripten recently adopted the default behavior of Closure, which is--language-in UNSTABLEsince 3.1.71. Using any other language breaks our build. So this PR is needed not necessarily now, but if we ever want to update emscripten past 3.1.70.See these links for more info:
--language-in UNSTABLEdue to public class fields emscripten-core/emscripten#23179 (comment)This will enable us to streamline our code, including the use of public class fields.