-
-
Notifications
You must be signed in to change notification settings - Fork 966
Bump the pre-commit group with 5 updates #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−5
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit-hooksv6.0.0 requires Python >= 3.9. This repo still supports Python 3.7/3.8 (seepython_requires/ tox env list), andtox -e miscrunspre-commit, so contributors (or CI jobs) invoking pre-commit under 3.7/3.8 will fail to create the hook environment. Consider either pinningpre-commit-hooksto <6, or explicitly ensuring pre-commit runs with Python >= 3.9 (e.g., run themisctox env only on >=3.9 and/or set adefault_language_versionfor python hooks).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it was okay for this to be non-blocking, but it makes a reasonable point--although it's been a long time since our
pre-commithooks all worked on the lowest version of Python that GitPython supports, it may make sense to do something to make this clear.I think Copilot is correct that we can use
default_language_versionto make the hooks run with a different version. This feels like it would be even better, but I'm not sure. I think it would be confusing to have that happen when running it from inside a virtual environment for an earlier version, and still not work if no such interpreter is available. Therefore I suspect just a comment, or even just a clear note in the readme, would be better. But I haven't looked into it.