Add read-only regression coverage for aliases and toolsets#2193
Open
davidahmann wants to merge 1 commit intogithub:mainfrom
Open
Add read-only regression coverage for aliases and toolsets#2193davidahmann wants to merge 1 commit intogithub:mainfrom
davidahmann wants to merge 1 commit intogithub:mainfrom
Conversation
Author
|
User impact: This locks in the current fail-closed behavior so future inventory changes do not silently re-expose write tools through dynamic toolsets or deprecated aliases.
Inspired by research context: CAISI publishes independent, reproducible AI agent governance research: https://caisi.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Read-only filtering already covers dynamic toolsets and deprecated aliases, but there was no dedicated regression coverage for those two paths, so a future inventory change could silently re-expose write tools.
Why now
Issue #2192 narrowed this to test coverage after confirming the current runtime is already fail-closed. The gap is in preserving that contract.
What changed
ToolsForToolsetread-only regression test for dynamic toolset enablementForMCPRequestValidation
go test ./pkg/inventory -run 'TestToolsForToolset_RespectsReadOnly|TestForMCPRequest_ToolsCall_DeprecatedAliasRespectsReadOnly'Refs #2192