[log] Add debug logging to difc/resource.go#1664
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
[log] Add debug logging to difc/resource.go#1664github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
Add logResource logger to internal/difc/resource.go with meaningful debug logging calls in key DIFC data aggregation and filtering methods: - CollectionLabeledData.Overall(): log item count when aggregating labels - FilteredCollectionLabeledData.Overall(): log accessible/filtered counts - FilteredCollectionLabeledData.ToResult(): log result statistics with filter reason Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
logResourcedebug logger tointernal/difc/resource.goand introduces 3 meaningful logging calls in key DIFC label aggregation and filtering methods.Changes
File modified:
internal/difc/resource.goimport "github.com/github/gh-aw-mcpg/internal/logger"var logResource = logger.New("difc:resource")CollectionLabeledData.Overall()"Aggregating labels for collection: items=%d"FilteredCollectionLabeledData.Overall()"Aggregating labels for filtered collection: accessible=%d, filtered=%d"FilteredCollectionLabeledData.ToResult()"Producing filtered collection result: accessible=%d, filtered=%d, reason=%s"Why these locations?
The
difc/resource.gofile contains the core DIFC data structures for label aggregation and filtering. These methods are called during every tool invocation to determine what data an agent can access. Adding logging here:logResource.Printf()which is a no-op unlessDEBUG=difc:*is setTesting
Enable debug logging to see the new output:
DEBUG=difc:* ./awmg --config config.tomlQuality Checklist
pkg:filenameconvention (difc:resource)len()(built-in, no side effects)