Open
Conversation
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/discard
branch
3 times, most recently
from
2a38483 to
755225f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the C/C++ overlay entity discard mechanism to decide discardability based on TRAP/tag reachability from source files, rather than relying on extracted file paths.
Changes:
- Replace file-path-based discard logic with predicates that track whether an element is in, and reachable via, a TRAP file or tag in base vs overlay variants.
- Tighten discard conditions to retain entities that are reachable from overlay sources, and to account for base reachability vs overlay changes/redefinitions/re-extractions.
igfoo
reviewed
Mar 9, 2026
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
IdrissRio
force-pushed
the
idrissrio/cpp/overlay/discard
branch
from
595fc75 to
4c6f355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.