Merged
Conversation
This was referenced Sep 22, 2023
erik-krogh
reviewed
May 16, 2024
Comment on lines
+15
to
+18
| .getMember([ | ||
| "exec", "cd", "cp", "touch", "chmod", "pushd", "find", "ls", "ln", "mkdir", "mv", | ||
| "rm", "cat", "head", "sort", "tail", "uniq", "grep", "sed", "to", "toEnd", "echo" | ||
| ]) |
Contributor
There was a problem hiding this comment.
I took a look at the type-definition of ShellJS, and from that documentation it appears that only some of the functions behave the way you have modelled here.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/shelljs/index.d.ts#L830
However, looking at the implementation (and specifically this PR), it seems that the type is misleading, and that your model is correct.
Contributor
|
I also did some small internal evaluations, and they showed no difference in results or performance. |
Contributor
Author
|
@erik-krogh can I mark this pull request as Ready for review? |
Contributor
Yes. |
erik-krogh
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Shelljs package has a piping feature and I've updated the current shelljs module to support piping too.