@maikypedia are you still working on this? Can I help with anything?

@maikypedia are you still working on this? Can I help with anything?

Hi @geoffw0 , the query is already finished, only the tests are missing but I am not familiar with writing stubs for swift 😅

OK, please would you move the query from src/queries/Security/CWE-078 to src/experimental/Security/CWE-078 (this excludes it from the default code scanning query suite, for now). Then I can merge it, add the tests and any other necessary changes, and move it out of experimental when everything is ready.

Thanks!

PS: I can @mention you in the PR(s) I make if you want to follow along.

OK, please would you move the query from src/queries/Security/CWE-078 to src/experimental/Security/CWE-078 (this excludes it from the default code scanning query suite, for now). Then I can merge it, add the tests and any other necessary changes, and move it out of experimental when everything is ready.

Thanks!

PS: I can @mention you in the PR(s) I make if you want to follow along.

Done 😁

QHelp previews:

var task = Process()
task.launchPath = "/bin/bash"
task.arguments = ["-c", userControlledString] // BAD

task.launch()

func validateCommand(_ command: String) -> String? {
    let allowedCommands = ["ls -l", "pwd", "echo"]
    if allowedCommands.contains(command) {
        return command
    }
    return nil
}

var task = Process()
task.launchPath = "/bin/bash"
task.arguments = ["-c", validateCommand(userControlledString)] // GOOD

task.launch()