ref: Add _is_segment() to streaming spans (12)#5619
Open
sentrivana wants to merge 5 commits intoivana/span-first-11-samplingfrom
Open
ref: Add _is_segment() to streaming spans (12)#5619sentrivana wants to merge 5 commits intoivana/span-first-11-samplingfrom
_is_segment() to streaming spans (12)#5619sentrivana wants to merge 5 commits intoivana/span-first-11-samplingfrom
Conversation
sentrivana
changed the title
_is_segment() to streaming spans_is_segment() to streaming spans (12)
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 1656 passed | ⏭️ 217 skipped | Total: 1873 | Pass Rate: 88.41% | Execution Time: 2m 4s All tests are passing successfully. ❌ Patch coverage is 50.00%. Project has 11999 uncovered lines. Files with missing lines (2)
Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
ericapisani
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)