X Tutup
Skip to content

Improved dialogs#51

Merged
gbaychev merged 2 commits intogbaychev:masterfrom
Baltasarq:dialog_sizes
Sep 15, 2020
Merged

Improved dialogs#51
gbaychev merged 2 commits intogbaychev:masterfrom
Baltasarq:dialog_sizes

Conversation

@Baltasarq
Copy link
Contributor

This is a modification of two dialogs that needed more size and better placement.

  • OptionsDialog: Needed more size and more minimum size.
  • PDFExportOptions: Needed more size and ok/cancel buttons relocation.

options_dialog
pdf_export_options_dialog

PDFExportOptions:

  • Relocation of buttons was done in the designer (PDFExportOptions.Designer.cs), but the resizing was done in the PDFExportOptions.cs. Anyway, this is compatible with the designer.

OptionsDialog:

  • Resizing was done in the designer. This is probably not compatible with the designer. I'll probably fix this.

@Baltasarq
Copy link
Contributor Author

OptionsDialog

Fixed. The resizing was done in the designer, and the minimum size was put in the OptionsDialog.cs file. This is totally compatible with the designer in the future.

@gbaychev gbaychev merged commit 856b918 into gbaychev:master Sep 15, 2020
@gbaychev
Copy link
Owner

Great, thank you once more!

@Baltasarq
Copy link
Contributor Author

There is still a dialog missing: PDFExportFinished. The problem is that I'm unable to compile NClass anymore.

$ xbuild PDFExport/PDFExport.csproj
NClassFontResolver.cs(17,7): error CS0246: The type or namespace name 'PdfSharp' could not be found (are you missing a using directive or an assembly reference?)
...
PDFGraphics.cs(446,24): error CS0246: The type or namespace name 'XGraphicsPath' could not be found (are you missing a using directive or an assembly reference?)
PDFGraphics.cs(446,24): error CS0246: The type or namespace name 'XGraphicsPath' could not be found (are you missing a using directive or an assembly reference?)

It seems I'm missing PDFSharp (that did not happen before, I only have NReflect), and X-something. What do I have to do to have to include and how, in order to get the executable?

@gbaychev
Copy link
Owner

Yes, I needed to switch from PdfSharp to PDFsharp-gdi nuget package. You need to restore your nuget packages (at least of the PdfExport project), visual studio does this automatically, but I don't know if/which IDE you use.

@Baltasarq
Copy link
Contributor Author

Baltasarq commented Sep 15, 2020

Yes, I needed to switch from PdfSharp to PDFsharp-gdi nuget package. You need to restore your nuget packages (at least of the PdfExport project), visual studio does this automatically, but I don't know if/which IDE you use.

I fixed that installing nuget CLI and executing nuget restore. Right now I am without IDE, since Rider has stopped working for mono projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup