chore: Use detect for React version in ESLint configuration#449
Open
yush-1018 wants to merge 1 commit intoelement-hq:mainfrom
Open
chore: Use detect for React version in ESLint configuration#449yush-1018 wants to merge 1 commit intoelement-hq:mainfrom
yush-1018 wants to merge 1 commit intoelement-hq:mainfrom
Conversation
yush-1018
requested review from
dbkr and
robintown
and removed request for
a team
Author
|
Hi, @robintown I'd like to work on this issue. I've created a PR with the fix — changed the hardcoded React version from "17" to "detect" so ESLint automatically picks up the correct version from package.json. Thanks!!😊 |
Author
|
The unit test failure is due to the SonarCloud step not having access to the SONARCLOUD_TOKEN secret, which is expected for fork-based PRs. The actual test suite and lint checks have passed successfully. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448