feat: promisify session.getBlobData()#17303
Merged
codebytere merged 1 commit intomasterfrom Mar 14, 2019
Merged
Conversation
codebytere
force-pushed
the
promisify-session-getblobdata
branch
from
b619aa4 to
faa97e2
Compare
codebytere
force-pushed
the
promisify-session-getblobdata
branch
from
faa97e2 to
896ba3b
Compare
codebytere
force-pushed
the
promisify-session-getblobdata
branch
3 times, most recently
from
8f6f474 to
e0470f9
Compare
zcbenz
suggested changes
Mar 13, 2019
codebytere
added
semver/major
codebytere
force-pushed
the
promisify-session-getblobdata
branch
from
0c7cc4c to
f8e0e25
Compare
codebytere
force-pushed
the
promisify-session-getblobdata
branch
from
f8e0e25 to
c5fffe3
Compare
zcbenz
approved these changes
Mar 14, 2019
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisifies
session.getBlobData().cc @deepak1556 @miniak @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Converted
session.getBlobData()to return a Promise instead of taking a callback.