feat: promisify session.clearAuthCache()#17259
Merged
codebytere merged 2 commits intomasterfrom Mar 9, 2019
Merged
Conversation
codebytere
force-pushed
the
promisify-clearauthcache
branch
5 times, most recently
from
203b76b to
3ca656b
Compare
codebytere
added
semver/major
codebytere
force-pushed
the
promisify-clearauthcache
branch
from
3ca656b to
dffb858
Compare
miniak
approved these changes
Mar 8, 2019
codebytere
force-pushed
the
promisify-clearauthcache
branch
from
dffb858 to
9789d15
Compare
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisifies
session.clearAuthCache().Checklist
npm testpassesRelease Notes
Notes: Converted
session.clearAuthCache()to return a promise instead of optionally taking a callback.