feat: promisify session proxy methods#17222
Merged
codebytere merged 1 commit intomasterfrom Mar 8, 2019
Merged
Conversation
deepak1556
reviewed
Mar 4, 2019
Member
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
LGTM, with some code style changes.
codebytere
commented
Mar 4, 2019
5 tasks
miniak
requested changes
Mar 7, 2019
codebytere
force-pushed
the
promise-session-proxy
branch
2 times, most recently
from
76e6c6d to
1cacc87
Compare
miniak
requested changes
Mar 8, 2019
codebytere
force-pushed
the
promise-session-proxy
branch
2 times, most recently
from
a8c1397 to
48ecf61
Compare
miniak
approved these changes
Mar 8, 2019
codebytere
force-pushed
the
promise-session-proxy
branch
from
48ecf61 to
16020a0
Compare
codebytere
force-pushed
the
promise-session-proxy
branch
from
16020a0 to
9212388
Compare
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisify
session.setProxy()andsession.resolveProxy().cc @deepak1556 @zcbenz @miniak
Checklist
npm testpassesRelease Notes
Notes: Converted
session.setProxy()andsession.resolveProxy()to return Promises instead of taking callbacks.