feat: promisify session cache methods#17185
Merged
codebytere merged 1 commit intomasterfrom Mar 8, 2019
Merged
Conversation
codebytere
force-pushed
the
promisify-session
branch
from
1b9066b to
c542b9e
Compare
deepak1556
requested changes
Mar 2, 2019
miniak
reviewed
Mar 3, 2019
codebytere
force-pushed
the
promisify-session
branch
from
5ce4a17 to
f4617b8
Compare
Member
|
Would like to see this cleaned up after the suggested code style changes in #17222 |
codebytere
force-pushed
the
promisify-session
branch
from
f4617b8 to
9a60256
Compare
codebytere
changed the title
codebytere
changed the title
miniak
requested changes
Mar 7, 2019
miniak
approved these changes
Mar 7, 2019
codebytere
force-pushed
the
promisify-session
branch
from
54cff0a to
f2f444c
Compare
deepak1556
approved these changes
Mar 8, 2019
Member
deepak1556
left a comment
deepak1556
left a comment
There was a problem hiding this comment.
LGTM, with some style changes.
codebytere
force-pushed
the
promisify-session
branch
from
f2f444c to
961c038
Compare
codebytere
force-pushed
the
promisify-session
branch
from
961c038 to
2f8d113
Compare
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisify
session.getCacheSize()andsession.clearCache().cc @deepak1556 @zcbenz
Checklist
npm testpassesRelease Notes
Notes: Converted
session.getCacheSize()andsession.clearCache()to return promises instead of taking callbacks.