Merged
Conversation
codebytere
changed the title
codebytere
force-pushed
the
promise-dock-show
branch
from
770d497 to
ae90c43
Compare
MarshallOfSound
approved these changes
Feb 12, 2019
Member
|
Only comment, is it at all possible to test this? |
codebytere
changed the title
Member
Author
|
i'm not sure how CI would react to this but i can test that the promise resolves i guess? |
codebytere
force-pushed
the
promise-dock-show
branch
from
4e63137 to
da8b959
Compare
codebytere
changed the title
codebytere
force-pushed
the
promise-dock-show
branch
from
da8b959 to
293f8d8
Compare
Member
Author
flaked on linux x64 which is unrelated. |
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Resolves #13047.
app.dock.show()was previously an asynchronous function that did not take a callback, so devs needed to employ unsavory timeouts and other things in order to give deterministic behavior to their users. This converts that method to return a Promise, which ameliorates that issue and also serves the modernization initiative.cc @miniak @deepak1556 @ckerr @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Converted
app.dock.show()such that it now returns a Promise.