feat: promisify netLog.stopLogging()#16862
Merged
alexeykuzmin merged 1 commit intomasterfrom Feb 19, 2019
Merged
Conversation
miniak
force-pushed
the
miniak/promisify-netlog
branch
2 times, most recently
from
a0285f0 to
ba62322
Compare
miniak
force-pushed
the
miniak/promisify-netlog
branch
from
ba62322 to
8352b46
Compare
codebytere
reviewed
Feb 13, 2019
miniak
force-pushed
the
miniak/promisify-netlog
branch
2 times, most recently
from
3196558 to
0730e60
Compare
jkleinsc
requested changes
Feb 15, 2019
Member
jkleinsc
left a comment
jkleinsc
left a comment
There was a problem hiding this comment.
Looks good to me except for a small doc change.
miniak
force-pushed
the
miniak/promisify-netlog
branch
from
0730e60 to
ce9d63e
Compare
codebytere
approved these changes
Feb 15, 2019
jkleinsc
approved these changes
Feb 15, 2019
Member
|
Arm CI is failing on this PR for a reason unrelated to this PR. #16992 will resolve that issue. |
Contributor
Author
|
@jkleinsc can you please merge? |
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR promisifies
netLog.stopLogging()Depends on #16935
/cc @codebytere
Checklist
npm testpassesRelease Notes
Notes: Converted
netLog.stopLogging()to return a Promise instead of taking a callback.