feat: promisify contentTracing recording APIs#16584
Merged
codebytere merged 4 commits intomasterfrom Jan 31, 2019
Merged
Conversation
codebytere
changed the title
codebytere
changed the title
codebytere
changed the title
codebytere
force-pushed
the
promisify-startrecording
branch
from
4615ef4 to
1b769c9
Compare
miniak
requested changes
Jan 30, 2019
codebytere
force-pushed
the
promisify-startrecording
branch
2 times, most recently
from
d5f9023 to
62afad9
Compare
miniak
approved these changes
Jan 30, 2019
ckerr
approved these changes
Jan 30, 2019
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
I love the improvements you made here to lib/browser/api/content-tracing.js
codebytere
force-pushed
the
promisify-startrecording
branch
from
62afad9 to
0d50720
Compare
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "5-0-x" cleanly; |
codebytere
added a commit
that referenced
this pull request
Jan 31, 2019
* feat: promisify contentTracing.startRecording() * feat: promisify contentTracing.stopRecording() * test: convert specs for new promisified apis * chore: deprecate and ensure legacy tests work
6 tasks
codebytere
added a commit
that referenced
this pull request
Feb 1, 2019
* feat: promisify contentTracing.startRecording() * feat: promisify contentTracing.stopRecording() * test: convert specs for new promisified apis * chore: deprecate and ensure legacy tests work
codebytere
added a commit
that referenced
this pull request
Feb 1, 2019
* feat: promisify contentTracing.startRecording() * feat: promisify contentTracing.stopRecording() * test: convert specs for new promisified apis * chore: deprecate and ensure legacy tests work
codebytere
added a commit
that referenced
this pull request
Feb 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Promisify
contentTracing.startRecording()andcontentTracing.stopRecording()cc @ckerr @deepak1556
Checklist
npm testpassesRelease Notes
Notes: Converted
contentTracing.startRecording()andcontentTracing.stopRecording()to return a promise instead taking a callback.