Add support for --type=secret in docker inspect#32124
Conversation
|
design LGTM |
cli/command/system/inspect.go
Outdated
vdemeester
force-pushed
the
system-inspect-secret
branch
from
eee4188 to
533511f
Compare
|
That is great. Thanks a lot. @vdemeester |
Right, I was waiting for it to pass |
|
design lgtm |
|
oh, when updating; perhaps you can also update the completion scripts 🤗 |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
system-inspect-secret
branch
from
533511f to
71129f6
Compare
|
@thaJeztah completions scripts updated (cc @sdurrheimer @albers) |
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
code LGTM, but needs updates to the documentation as mentioned above 😄
|
docs is being taken care of in #32112 |
|
Bash completion tested locally, perfect! |
|
LGTM |
|
pssst @ehazlett; looks like it can be moved to |
| __docker_complete_nodes && ret=0 | ||
| elif [[ ${words[(r)--type=plugin]} == --type=plugin ]]; then | ||
| __docker_complete_plugins && ret=0 | ||
| elif [[ ${words[(r)--type=service]} == --type=secrets ]]; then |
There was a problem hiding this comment.
Sorry for looking at this too late, should be elif [[ ${words[(r)--type=secrets]} not elif [[ ${words[(r)--type=service]}
There was a problem hiding this comment.
oh shit, my bad I missed one 😱 I'll fix 👼
There was a problem hiding this comment.
Oh, thanks of the catch; can you open a pull request to fix that, or want someone else to do that?
Add support for `--type=secret` in `docker inspect`
7 participants
Taking into account @allencloud, add support for
docker inspect --type=secretbecause, why not 👼./cc @icecrime
@thaJeztah @cpuguy83 @AkihiroSuda @dnephin @tiborvass @vieux
🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm