This repository was archived by the owner on Nov 17, 2024. It is now read-only.
ignore actions on not-yet loaded sounds; improve migration ⚡ #532
Merged
CosmoMyzrailGorynych merged 2 commits intoct-js:developfrom Jul 20, 2024
Merged
ignore actions on not-yet loaded sounds; improve migration ⚡ #532CosmoMyzrailGorynych merged 2 commits intoct-js:developfrom
CosmoMyzrailGorynych merged 2 commits intoct-js:developfrom
Conversation
- sound actions on sounds that haven't been loaded are now ignored - sound.playing returns false for sounds not yet loaded instead of crashing - strip ct from ct.tween - delete deprecated mouse catmod on 4.0.1 migration to prevent crash
CosmoMyzrailGorynych
approved these changes
Jul 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partially resolves #507
Ping @CosmoMyzrailGorynych