✨ Catmod Game Distribution#394
Conversation
# Added a new Catmod for Game Distribution Ads in the ct.libs # Added a new Example in the Examples folder
Removed .vscode\settings.json Removed empty files and folder injections Updated docs Changed al the if statements of true from this if(ct.gamedistribution.isFinished == true) to this if(ct.gamedistribution.isFinished)
CosmoMyzrailGorynych
left a comment
CosmoMyzrailGorynych
left a comment
There was a problem hiding this comment.
Well,
There is misleading stuff here and there, typos, and just improper newbie JS code that must not be taught to others. And ideally — not used in code, too.
General advice: use either "Ad" or "Banner", not both.
One event is useless.
app/data/ct.libs/gamedistribution/events/pausegame_thisOnStep.js
Outdated
Show resolved
Hide resolved
app/data/ct.libs/gamedistribution/events/resumegame_thisOnStep.js
Outdated
Show resolved
Hide resolved
app/data/ct.libs/gamedistribution/events/showadonclick_thisOnStep.js
Outdated
Show resolved
Hide resolved
app/data/ct.libs/gamedistribution/events/showadonclick_thisOnStep.js
Outdated
Show resolved
Hide resolved
Removed all boolean compare == to if(something) or if(!something) Removed the useless event that mislead the use of pointer Remvved unnecesary parts in Generall use.md Changed showBanner to showAd Game example updated to remove the event showadonclick_thisOnStep. In General use.md fixed som typos and added Catmods' settings instead of Catmod settings
CosmoMyzrailGorynych
left a comment
CosmoMyzrailGorynych
left a comment
There was a problem hiding this comment.
Added 3 new comments. Awaiting for previous fixes, too.
| Inside a `Click` event add this code: | ||
|
|
||
| ```js | ||
| if (ct.gamedistribution.adPlaying) { |
There was a problem hiding this comment.
isn't it if (!ct.gamedistribution.adPlaying) {?
| setTimeout( | ||
| function() { | ||
| ct.gamedistribution.isFinished = false; | ||
| }, | ||
| 0 |
There was a problem hiding this comment.
I don't think this method should change the value ct.gamedistribution.isFinished. It is counterintuitive.
| @@ -0,0 +1,77 @@ | |||
| { | |||
There was a problem hiding this comment.
It would be better if this module was in another PR. I can still merge it if it is not a mistake.
There was a problem hiding this comment.
Sure I messed up with the pull request the ct.ulid it's a different Catmod, not related at all with the GameDistribution, sorry for that, just let me finish with the GD, then I'm going to create another pull for the ct.ulid.
Removed from index.js and from types.d.ts the function isAdFinished since there is an event to manage if the Ad has finished.
In General use.md: Replaced if (ct.gamedistribution.adPlaying) { to if (!ct.gamedistribution.adPlaying) {
In module.js Replaced :
"name": "Ad is finished",
"parameterizedName": "Check if an Ad is finished.",
to
"name": "Ad has finished",
"parameterizedName": "Check if an Ad has finished.",
Removed the parametrizedName sin I didn't know there is no need to use it if there is no parameters to display.
Added .vscode to .gitignore so is not included the pull.
|
@UlisesFreitas should I merge ct.ulid with this, or wait for you to remove it from this PR? |
|
Hi sure merge ct.ulid from here, in the future I'll make sure to just push catmods in differents PR. |
2 participants
gulp buildruns without issues.WIP:prefix.Changes proposed in this pull request:
Add a new catmod for the useers to use the Game Distribution SDK to display Ads in their games.
Ping @CosmoMyzrailGorynych