fix(braces): F+ for ; after {} in struct/union reference#389
Open
aaronliu0130 wants to merge 3 commits intocpplint:developfrom
Open
fix(braces): F+ for ; after {} in struct/union reference#389aaronliu0130 wants to merge 3 commits intocpplint:developfrom
aaronliu0130 wants to merge 3 commits intocpplint:developfrom
Conversation
Immunize lines with `&(struct` in them
There was a problem hiding this comment.
Pull request overview
This PR fixes a false positive in the trailing semicolon checker that incorrectly flagged compound literal references (address-of expressions with struct compound literals like &(struct name){}) as having unnecessary semicolons. The fix adds a condition to skip the warning when the code contains the pattern of an ampersand followed by a struct compound literal.
- Adds logic to detect and exempt
&(struct ...){}patterns from semicolon warnings - Includes a test case to verify the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cpplint.py | Adds check to suppress semicolon warnings for struct compound literal references by detecting & before (struct pattern |
| cpplint_unittest.py | Adds test case verifying &(struct mount_attr){} doesn't trigger false positive |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aaronliu0130
commented
Nov 28, 2025
let's see if the \s makes the tests fail Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
aaronliu0130
changed the title
aaronliu0130
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Immunize lines with
&(structin themShould fix #201