Merged
Conversation
deanberris
requested changes
Mar 1, 2017
Member
deanberris
left a comment
deanberris
left a comment
There was a problem hiding this comment.
Some changes seem unnecessary and unrelated.
| if (boost::empty(content_type_headers)) { | ||
| typedef typename char_<Tag>::type char_type; | ||
| static char_type content_type[] = "x-application/octet-stream"; | ||
| static char_type* content_type = "x-application/octet-stream"; |
Member
There was a problem hiding this comment.
Why do you need to make this change?
| if (boost::empty(content_type_headers)) { | ||
| typedef typename char_<Tag>::type char_type; | ||
| static char_type content_type[] = "x-application/octet-stream"; | ||
| static char_type* content_type = "x-application/octet-stream"; |
Author
Author
|
Corrected to only ICC fixes. |
|
@deanberris @glynos status? |
Member
|
LGTM I'm not sure this is actually a valid change to make -- I don't understand why ICC isn't able to just initialise the character array with a literal, as that's valid C++. However, if this is something that's actively blocking adoption, then I suppose merging it is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.