add client size close for 0.13-release#719
Merged
deanberris merged 2 commits intocpp-netlib:0.13-releasefrom Dec 15, 2016
Merged
add client size close for 0.13-release#719deanberris merged 2 commits intocpp-netlib:0.13-releasefrom
deanberris merged 2 commits intocpp-netlib:0.13-releasefrom
Conversation
anonimal
reviewed
Dec 14, 2016
| headers.insert(header_pair); | ||
| if (boost::iequals(header_pair.first, "Content-Length")) { | ||
| is_content_length = true; | ||
| content_length = std::stoi(header_pair.second); |
There was a problem hiding this comment.
std::stoi(maliciously large amount)
And what if std::out_of_range is thrown? Would this be caught earlier/later?
Author
There was a problem hiding this comment.
Any Content-Length greater than or equal to zero is a valid value.If Content-Length is larger than long long , I will ignore to handle it.Please check again,thanks~
deanberris
approved these changes
Dec 15, 2016
Member
deanberris
left a comment
deanberris
left a comment
There was a problem hiding this comment.
LGTM -- thanks @chenzhaoyu and @anonimal for the review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.