X Tutup
Skip to content

[Scala3] Add cross-compiling tests#5141

Merged
jackkoenig merged 1 commit intomainfrom
adkian-sifive/scala3-testing-first-pass
Jan 12, 2026
Merged

[Scala3] Add cross-compiling tests#5141
jackkoenig merged 1 commit intomainfrom
adkian-sifive/scala3-testing-first-pass

Conversation

@adkian-sifive
Copy link
Contributor

@adkian-sifive adkian-sifive commented Jan 9, 2026

Move 72 spec files from src/test/scala-2 to src/test/scala. Minor updates for Scala 3 compilation

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Feature (or new API)
  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Add tests that cross-compile and run with Scala 2/3

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Jan 9, 2026
@jackkoenig
Copy link
Contributor

My one complaint is that this makes CI a lot slower because Scala 2.13 and 3 are in the same bucket. I'll look into fixing that...

@jackkoenig jackkoenig merged commit feac0a0 into main Jan 12, 2026
20 checks passed
@jackkoenig jackkoenig deleted the adkian-sifive/scala3-testing-first-pass branch January 12, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup