Merged
Conversation
Now text speed options for 2-click Context-sensitive SettingsBar component are configured as properties of itself instead of relying on Popochiu and PopochiuSettings. - [fea] Add `is_playing_cue` function to AudioManager so one can now if a PopochiuAudioCue is playing. - [fea] When a PopochiuCharacter stops speaking, its voice stops too if it is still playing. For this to work properly, the PopochiuAudioCue should not be marked as `can_play_simultaneous`. - [upd] Now moving the GUI to "res://game/graphic_interface" takes into accound if a script is a tool so it adds the @tool annotation to the target file. - [upd] Room tab selects the scene of created Markers in the FileSystem when clicking the Marker row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now text speed options for 2-click Context-sensitive SettingsBar component are configured as properties of itself instead of relying on Popochiu and PopochiuSettings.
is_playing_cuefunction to AudioManager so one can now if a PopochiuAudioCue is playing.can_play_simultaneous.