POM Cleanup: Add Maven descriptors & remove mention of Travis CI#1057
Merged
sbittrich merged 3 commits intobiojava:masterfrom Apr 5, 2023
Merged
POM Cleanup: Add Maven descriptors & remove mention of Travis CI#1057sbittrich merged 3 commits intobiojava:masterfrom
sbittrich merged 3 commits intobiojava:masterfrom
Conversation
josemduarte
approved these changes
Apr 3, 2023
Contributor
josemduarte
left a comment
josemduarte
left a comment
There was a problem hiding this comment.
LGTM thanks.
There's an unrelated test failure. It seems due to an obsoleted PDB id. I'll try to push a fix to master, so that then this can be tested.
Contributor
|
Ok I committed a fix: could you merge master in, so that tests run? |
Contributor
|
Actually there were a couple more test issues (after recent remediation of some PDB entries). Now I think I fixed them all. Please try again. |
Member
Author
|
Thanks for updating the tests. Let's see how this goes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pom.propertiesfiles when using BioJava as dependency