Perf: conditional execution for extract_skins system#23278
Open
aevyrie wants to merge 1 commit intobevyengine:mainfrom
Open
Perf: conditional execution for extract_skins system#23278aevyrie wants to merge 1 commit intobevyengine:mainfrom
extract_skins system#23278aevyrie wants to merge 1 commit intobevyengine:mainfrom
Conversation
…e of skinned meshes
atlv24
approved these changes
Mar 9, 2026
IceSentry
approved these changes
Mar 9, 2026
IceSentry
added
A-Rendering
Contributor
|
I think this is wrong because it doesn't handle the case in which you had skins but they went away (see |
pcwalton
added a commit
to pcwalton/bevy
that referenced
this pull request
Mar 9, 2026
Currently, we try to use `Changed<GlobalTransform>` as a way to accelerate extraction of joints. This was a valiant attempt, but it's thwarted by the fact that we don't have change indexes, and so it incurs full table scans of all entities with `GlobalTransform` components. This patch changes `extract_skins` to simply iterate through all the joints and fetch their transforms. When we have change indexes, we can restore the original code, or something like it. This PR is an alternative to bevyengine#23278 that should be correct when skins are removed.
Member
|
I much prefer #23283 because it's a more principled fix; review that please? |
alice-i-cecile
added
S-Nominated-To-Close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
extract_skins. This was significant - 10ms in a 30ms frame.Solution
Testing