Fixes sub-array (opencl, oneapi) support for reduce by key#3665
Merged
christophe-murphy merged 3 commits intoarrayfire:masterfrom Jun 27, 2025
Conversation
willyborn
changed the title
Revert line breaks. While these lines are quite long, introducing more breaks here makes it more difficult to read.
christophe-murphy
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using sub-arrays in the reduceByKey function results in undefined behaviour in the opencl & oneapi backend.
Description
The offsets were not taken into account in the opencl & oneapi code.
28bd6b0: adds the the function toTempFormat to the test helpers. This function generates the different temporary array formats (JIT array, SUB-array, Linear array, ...) used by arrayfire.
d0bf731: Adds the offset to the cl code files & adds extra tests for scan.
Changes to Users
None
Checklist