unified reports filled af::exception errors.#3617
Merged
christophe-murphy merged 1 commit intoarrayfire:masterfrom Oct 22, 2024
Merged
unified reports filled af::exception errors.#3617christophe-murphy merged 1 commit intoarrayfire:masterfrom
christophe-murphy merged 1 commit intoarrayfire:masterfrom
Conversation
willyborn
force-pushed
the
unifiedException
branch
from
a8f774d to
32bb1b7
Compare
christophe-murphy
approved these changes
Oct 22, 2024
Contributor
christophe-murphy
left a comment
christophe-murphy
left a comment
There was a problem hiding this comment.
Good catch, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unified version of arrayfire, an std::exception is throw while collecting the arrayfire global error message.
Now the arrayfire error message is collected from the correct platform, resulting in the throwing of an af::exception filled with info.
When checking the unified tests: 18 tests failed because an unexpected exception was thrown
Description
When collecting the error message from the underlying platform, the address of the corresponding function was incorrect, resulting in an access violation.
Result:
Fixes: #3276 #2346
Changes to Users
None
Checklist