X Tutup
Skip to content

Fix for issue 3528: cmake generator expression space removed#3554

Merged
christophe-murphy merged 1 commit intoarrayfire:masterfrom
edwinsolisf:issue3528
Aug 30, 2024
Merged

Fix for issue 3528: cmake generator expression space removed#3554
christophe-murphy merged 1 commit intoarrayfire:masterfrom
edwinsolisf:issue3528

Conversation

@edwinsolisf
Copy link
Contributor

@edwinsolisf edwinsolisf commented May 31, 2024 •
edited
Loading

Fixes CMake Generator Expression Issue with a system with no OpenCL installed compiles arrayfire without the OpenCL backend

Description

  • Is this a new feature or a bug fix?: Bug Fix
  • Why these changes are necessary: Fixes CMake Build
  • Potential impact on specific hardware, software or backends: Allows building non OpenCL ArrayFire backends without OpenCL installed in Linux
  • New functions and their functionality: None
  • Can this PR be backported to older versions?: Yes
  • Future changes not implemented in this PR: None

Fixes: #3528

Changes to Users

  • No options added to the build
  • No action required by the user

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@HugoPhibbs
Copy link

HugoPhibbs commented Jun 21, 2024

Is it also necessary to remove the space in the cmake expressions on lines 46-47?

    $<$<BOOL:${OpenCL_FOUND}>:${CMAKE_CURRENT_SOURCE_DIR}/opencl.cpp>
    $<$<BOOL:${CUDA_FOUND}>:${CMAKE_CURRENT_SOURCE_DIR}/cuda.cpp>

@edwinsolisf
Copy link
Contributor Author

edwinsolisf commented Jun 22, 2024

@HugoPhibbs It's not necessary. The problem reported was caused due to cmake generator expressions behaving weirdly with whitespace. See documentation. But I'll update those lines too, for consistency.

@christophe-murphy christophe-murphy merged commit 773c96b into arrayfire:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christophe-murphy christophe-murphy christophe-murphy approved these changes

Assignees

No one assigned

Labels

build fix Linux OpenCL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Build] Syntax error in CMake generator expression for OpenCL

3 participants

@edwinsolisf @HugoPhibbs @christophe-murphy
X Tutup