Loosen indexing assertions for af_assign_gen#3514
Merged
christophe-murphy merged 2 commits intoarrayfire:masterfrom Oct 1, 2024
Merged
Loosen indexing assertions for af_assign_gen#3514christophe-murphy merged 2 commits intoarrayfire:masterfrom
christophe-murphy merged 2 commits intoarrayfire:masterfrom
Conversation
umar456
force-pushed
the
indexing_assertions
branch
from
e3ffadf to
0ee8203
Compare
christophe-murphy
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a set of assertions in af_assign_gen. The assertions were incorrectly used the ndims parameter which is the number of indexes that are passed in against the dimension of the lhs of the assertion.
Description
Changes to Users
N/A
Checklist