Solves C7626 error when compiling with MSVC 2019 16.6+#3512
Merged
christophe-murphy merged 1 commit intoarrayfire:masterfrom Nov 6, 2024
Merged
Solves C7626 error when compiling with MSVC 2019 16.6+#3512christophe-murphy merged 1 commit intoarrayfire:masterfrom
christophe-murphy merged 1 commit intoarrayfire:masterfrom
Conversation
|
It seems the typedef grammar of KParam is not C++ style, after I change to the following code, the build succeeded. #ifndef OPENCL_VERSION |
christophe-murphy
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves error C7626 when compiling with MSVC 2019 16.6+
Description
See Microsoft C7626 description.
unnamed typedef classes can generate linkage problems. Starting from MSVC 2019 16.6+, error C7626 is generated when compiling with /std:c++17 or above.
Solution: give the typedef a name (I chose KParam_t)
PS: The linkage problem also exists with GCC and Clang (see P1766R1.)
Changes to Users
None
Checklist