Merged
Conversation
umar456
reviewed
Mar 14, 2023
vcpkg.json
Outdated
| "description": "Build OpenCL backend", | ||
| "dependencies": [ | ||
| "boost-compute", | ||
| "boost-program-options", |
Member
There was a problem hiding this comment.
I don't think this is a good dependency for the project. It is only required for some of the tests in the clFFT project and those aren't built. I think the vcpkg should minimize the number of dependencies installed whenever possible.
Contributor
Author
There was a problem hiding this comment.
OK.
I get it out, and resend the PR.
Contributor
Author
There was a problem hiding this comment.
Or should I move it to the openblasfftw section ?
Member
There was a problem hiding this comment.
You should remove it. We don't need that dependency to build ArrayFire.
willyborn
force-pushed
the
multithreadedOPENBLAS
branch
from
90dd9d7 to
7f242c8
Compare
umar456
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the threads options to OPENBLAS & FFT VCPKG compilation.
Description
Changes to Users
Improved speed when using OPENBLAS.
Checklist