Add assert that check if topk is called with a negative value for k#3176
Merged
umar456 merged 1 commit intoarrayfire:masterfrom Sep 30, 2021
Merged
Add assert that check if topk is called with a negative value for k#3176umar456 merged 1 commit intoarrayfire:masterfrom
umar456 merged 1 commit intoarrayfire:masterfrom
Conversation
syurkevi
approved these changes
Sep 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add checks to make sure K is greater than 0 for topk
Description
TopK fails if k is negative. This is not a proper value for TopK so we are adding assertions to make sure K is grater than 0.
Changes to Users
Checklist
[ ] Functions added to unified API[ ] Functions documented