Add support to cuDNN Dependency module to load verion 8 when available#2963
Merged
umar456 merged 1 commit intoarrayfire:masterfrom Jul 7, 2020
Merged
Add support to cuDNN Dependency module to load verion 8 when available#2963umar456 merged 1 commit intoarrayfire:masterfrom
umar456 merged 1 commit intoarrayfire:masterfrom
Conversation
Member
Author
|
@umar456 Wouldn't it be valid to lookup only versions same or earlier to the one current build is built with ? diff --git a/src/backend/cuda/cudnnModule.cpp b/src/backend/cuda/cudnnModule.cpp
index b76b0c65f..c1c6ab0b1 100644
--- a/src/backend/cuda/cudnnModule.cpp
+++ b/src/backend/cuda/cudnnModule.cpp
@@ -27,7 +27,10 @@ namespace cuda {
// clang-format off
// Latest version from each minor releases are enlisted below
constexpr std::array<common::Version, 11> cudnnVersions = {
+#if CUDNN_VERSION >= 8000
make_tuple(8, 0, 1),
+#endif
+#if CUDNN_VERSION >= 7000
make_tuple(7, 6, 5),
make_tuple(7, 5, 1),
make_tuple(7, 4, 2),
@@ -35,8 +38,13 @@ constexpr std::array<common::Version, 11> cudnnVersions = {
make_tuple(7, 2, 1),
make_tuple(7, 1, 4),
make_tuple(7, 0, 5),
+#endif
+#if CUDNN_VERSION >= 6000
make_tuple(6, 0, 21),
+#endif
+#if CUDNN_VERSION >= 5000
make_tuple(5, 1, 10),
+#endif
make_tuple(4, 0, 7)
};
// clang-format on |
umar456
previously approved these changes
Jul 6, 2020
Adds runtime support for cuDNN 8
umar456
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #2935
Changes to Users
None
Checklist
[ ] Functions added to unified API[ ] Functions documented