X Tutup
Skip to content

Fixed several errors on OSX with Apple Clang#2945

Merged
9prady9 merged 2 commits intoarrayfire:masterfrom
umar456:osx_fixes
Jun 26, 2020
Merged

Fixed several errors on OSX with Apple Clang#2945
9prady9 merged 2 commits intoarrayfire:masterfrom
umar456:osx_fixes

Conversation

@umar456
Copy link
Member

@umar456 umar456 commented Jun 25, 2020

Fixed several errors on OSX with Apple Clang

Description

This bugfix addresses errors compiling on Apple Clang. This PR

  • Adds Boost::boost target to the unified backend for stacktrace
  • Change getOpString to return a const char* to maintain constexpr specification
  • Make Array destructor default in the header instead of in the cpp file
  • Make all Node classes movable and add static asserts

In the future we should consider adding move constructors to dim4.

Fixes: #2944

Changes to Users

N/A

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@umar456 umar456 added the build label Jun 25, 2020
@umar456 umar456 added this to the 3.7.2 milestone Jun 25, 2020
@umar456 umar456 mentioned this pull request Jun 26, 2020
Closed
9prady9
9prady9 reviewed Jun 26, 2020
View reviewed changes
@9prady9 9prady9 merged commit f9e33b1 into arrayfire:master Jun 26, 2020
@umar456 umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees

No one assigned

Labels

build fix OSX

Projects

None yet

Milestone

3.7.2

Development

Successfully merging this pull request may close these issues.

[Build] OPENCL and CPU errors for Mac OS

2 participants

@umar456 @9prady9
X Tutup