Conversation
**Short description of change** Adds a github PR template for the ArrayFire project. Developers will now face a short suggested checklist when creating a new PR on github. **Motivation** Adding a PR template will make it easier to reference old issues when generating reports and link future issue in historical context. **Future considerations** Wiki might need to be updated with additional development guidelines. The current guidelines could be more comprehensive.
9prady9
previously approved these changes
Jun 12, 2020
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| **Short description of change** | |||
| Not the commit message. Description of what was done for an unfamiliar reviewer. | |||
* Added additional detail. * Use comments instead of text to communicate with the reader. * Create a simple checklist
umar456
approved these changes
Jun 18, 2020
umar456
added a commit
to umar456/arrayfire
that referenced
this pull request
Jun 27, 2020
* Adds PR template **Short description of change** Adds a github PR template for the ArrayFire project. Developers will now face a short suggested checklist when creating a new PR on github. **Motivation** Adding a PR template will make it easier to reference old issues when generating reports and link future issue in historical context. **Future considerations** Wiki might need to be updated with additional development guidelines. The current guidelines could be more comprehensive. * Updated pull request template * Added additional detail. * Use comments instead of text to communicate with the reader. * Create a simple checklist * Grammer + Future changes in the description section Co-authored-by: Umar Arshad <umar@arrayfire.com>
9prady9
pushed a commit
that referenced
this pull request
Jun 27, 2020
* Adds PR template **Short description of change** Adds a github PR template for the ArrayFire project. Developers will now face a short suggested checklist when creating a new PR on github. **Motivation** Adding a PR template will make it easier to reference old issues when generating reports and link future issue in historical context. **Future considerations** Wiki might need to be updated with additional development guidelines. The current guidelines could be more comprehensive. * Updated pull request template * Added additional detail. * Use comments instead of text to communicate with the reader. * Create a simple checklist * Grammer + Future changes in the description section Co-authored-by: Umar Arshad <umar@arrayfire.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of change
Adds a github PR template for the ArrayFire project. Developers will now face a short suggested checklist when creating a new PR on github.
Motivation
Adding a PR template will make it easier to reference old issues when generating reports and link future issue in historical context.
Future considerations
Wiki might need to be updated with additional development guidelines. The current guidelines could be more comprehensive.