Fix pinnedMemManager check. Fix MKL Sequential layer#2840
Merged
umar456 merged 2 commits intoarrayfire:masterfrom Apr 14, 2020
Merged
Fix pinnedMemManager check. Fix MKL Sequential layer#2840umar456 merged 2 commits intoarrayfire:masterfrom
umar456 merged 2 commits intoarrayfire:masterfrom
Conversation
Member
umar456
commented
Apr 14, 2020
umar456
commented
- The setMemorymanagerPinned function was incorrectly checking the function pointer instead of the pinnedMemManager pointer.
- MKL with the Sequential layer was broken because the ThreadingLibrary variable was required. The sequential layer does not have a threading library so MKL was set to not found because that variable was not set.
9prady9
requested changes
Apr 14, 2020
9prady9
approved these changes
Apr 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.