Fix NPE during VM setup for pvlan by sureshanaparti · Pull Request #12781 · apache/cloudstack

sureshanaparti · 2026-03-10T10:13:48Z

Description

This PR fixes NPE issue during VM setup for pvlan.

ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-5:[ctx-36c8ede2, job-51933/job-51934]) (logid:aad07025) Unable to complete AsyncJob {"accountId":2,"cmd":"com.cloud.vm.VmWorkMigrate","cmdInfo":"rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAAAAAAAAAACAAAAAAAAAFMAAAAAAAAAMHQAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAAAAAAAAEXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAAAAAAAAA3NxAH4ABwAAAAAAAAATc3EAfgAHAAAAAAAAAAFwcQB-AAs","cmdVersion":0,"completeMsid":null,"created":"Mon Feb 16 15:40:04 EST 2026","id":51934,"initMsid":90520733277145,"instanceId":null,"instanceType":null,"lastPolled":null,"lastUpdated":null,"processStatus":0,"removed":null,"result":null,"resultCode":0,"status":"IN_PROGRESS","userId":83,"uuid":"c3826ec3-3793-453c-bd0b-a79cbfbda7fe"}, job origin: 51933 java.lang.NullPointerException: Cannot invoke "java.net.URI.getScheme()" because the return value of "com.cloud.vm.NicProfile.getBroadCastUri()" is null at com.cloud.vm.UserVmManagerImpl.setupVmForPvlan(UserVmManagerImpl.java:5390) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:569) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215) at jdk.proxy3/jdk.proxy3.$Proxy219.setupVmForPvlan(Unknown Source) at org.apache.cloudstack.engine.orchestration.NetworkOrchestrator.prepareNicForMigration(NetworkOrchestrator.java:2278) at com.cloud.vm.VirtualMachineManagerImpl.migrate(VirtualMachineManagerImpl.java:3100) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateMigrate(VirtualMachineManagerImpl.java:3052) at com.cloud.vm.VirtualMachineManagerImpl.orchestrateMigrate(VirtualMachineManagerImpl.java:5978)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

sureshanaparti · 2026-03-10T10:14:10Z

@blueorangutan package

blueorangutan · 2026-03-10T10:16:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2026-03-10T10:35:54Z

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (9b7a8ab).

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12781      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
+ Complexity    15664    15663       -1     
============================================
  Files          5917     5917              
  Lines        531402   531408       +6     
  Branches      64971    64973       +2     
============================================
  Hits          93596    93596              
- Misses       427252   427258       +6     
  Partials      10554    10554

Flag	Coverage Δ
uitests	`3.70% <ø> (ø)`
unittests	`18.68% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Fixes a NullPointerException during VM pvlan setup by guarding against missing NIC broadcast URI (and missing host).

Changes:

Add null checks for NicProfile / getBroadCastUri() before accessing URI scheme.
Compare pvlan scheme safely using a local scheme variable and constant-first equals.
Add a host existence check (with a warning) before issuing the pvlan setup command.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-10T10:43:19Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

+        if (nic == null || nic.getBroadCastUri() == null) {
+            return false;
+        }
+
+        String scheme = nic.getBroadCastUri().getScheme();
+        if (!"pvlan".equals(scheme)) {


Returning false here makes the failure mode indistinguishable from the non-pvlan path (scheme != pvlan). Consider logging (at least debug/warn) why pvlan setup is being skipped (null NIC vs null broadcast URI) so future incidents are diagnosable.

Suggested change

if (nic == null || nic.getBroadCastUri() == null) {

return false;

}

String scheme = nic.getBroadCastUri().getScheme();

if (!"pvlan".equals(scheme)) {

if (nic == null) {

logger.debug("Skipping PVLAN setup on host {} because NIC profile is null", hostId);

return false;

}

if (nic.getBroadCastUri() == null) {

logger.debug("Skipping PVLAN setup on host {} for NIC with MAC {} because broadcast URI is null", hostId, nic.getMacAddress());

return false;

}

String scheme = nic.getBroadCastUri().getScheme();

if (!"pvlan".equals(scheme)) {

logger.debug("Skipping PVLAN setup on host {} for NIC with MAC {} because broadcast URI scheme is '{}'", hostId, nic.getMacAddress(), scheme);

Copilot · 2026-03-10T10:43:19Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

        Network network = _networkDao.findById(nic.getNetworkId());
        Host host = _hostDao.findById(hostId);
+        if (host == null) {
+            logger.warn("Host with id {} doesn't exist", hostId);
+            return false;
+        }


The network lookup is performed even when hostId is invalid and the method returns early. Consider fetching/validating host before calling _networkDao.findById(...) to avoid unnecessary DAO work in this error path.

Suggested change

Network network = _networkDao.findById(nic.getNetworkId());

Host host = _hostDao.findById(hostId);

if (host == null) {

logger.warn("Host with id {} doesn't exist", hostId);

return false;

}

Host host = _hostDao.findById(hostId);

if (host == null) {

logger.warn("Host with id {} doesn't exist", hostId);

return false;

}

Network network = _networkDao.findById(nic.getNetworkId());

Copilot · 2026-03-10T10:43:19Z

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

        Network network = _networkDao.findById(nic.getNetworkId());
        Host host = _hostDao.findById(hostId);
+        if (host == null) {
+            logger.warn("Host with id {} doesn't exist", hostId);


Consider changing the log message to avoid the contraction "doesn't" (e.g., "does not exist") for consistency and formality in logs.

Suggested change

logger.warn("Host with id {} doesn't exist", hostId);

logger.warn("Host with id {} does not exist", hostId);

blueorangutan · 2026-03-10T11:38:51Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 17068

Fix NPE during VM setup for pvlan

9b7a8ab

sureshanaparti requested a review from Copilot March 10, 2026 10:37

Copilot started reviewing on behalf of sureshanaparti March 10, 2026 10:43 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix NPE during VM setup for pvlan#12781

Fix NPE during VM setup for pvlan#12781
sureshanaparti wants to merge 1 commit intoapache:4.22from
shapeblue:npe-fix-during-setup-pvlan

sureshanaparti commented Mar 10, 2026

Uh oh!

sureshanaparti commented Mar 10, 2026

Uh oh!

blueorangutan commented Mar 10, 2026

Uh oh!

codecov bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

Copilot AI Mar 10, 2026

Uh oh!

blueorangutan commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	logger.warn("Host with id {} doesn't exist", hostId);
	logger.warn("Host with id {} does not exist", hostId);

Conversation

sureshanaparti commented Mar 10, 2026

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Mar 10, 2026

Uh oh!

blueorangutan commented Mar 10, 2026

Uh oh!

codecov bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 10, 2026 •

edited

Loading